Fix bazel build for 8437b7f5. #132046
Merged
Fix bazel build for 8437b7f5. #132046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-libc Author: James Y Knight (jyknight) ChangesWhen using parse_headers validation, rpc_server.h fails to build, since we don't expose any of the RPC deps in the Bazel build. So at least for now, just exclude it. Full diff: https://github.com/llvm/llvm-project/pull/132046.diff 1 Files Affected:
diff --git a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
index f3620186d776f..cae1202ec9f39 100644
--- a/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/libc/BUILD.bazel
@@ -1591,7 +1591,10 @@ libc_support_library(
libc_support_library(
name = "libc_external_common",
- hdrs = glob(["shared/*.h"]),
+ hdrs = glob(
+ ["shared/*.h"],
+ exclude = ["shared/rpc-server.h"],
+ ),
deps = [
":__support_common",
":__support_fputil_fp_bits",
|
jhuber6
approved these changes
Mar 19, 2025
Contributor
jhuber6
left a comment
jhuber6
left a comment
There was a problem hiding this comment.
Thanks, it's not really intended to be used internally anyways.
When using parse_headers validation, rpc_server.h fails to build, since we don't expose any of the RPC deps in the Bazel build. So at least for now, just exclude it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using parse_headers validation, rpc_server.h fails to build, since we don't expose any of the RPC deps in the Bazel build.
So at least for now, just exclude it.